On Windows, the app does not quit when window is closed

ituob / itu-ob-editor

Cross-platform desktop application for collaborative editing of ITU Operational Bulletin data

6 stars 3 forks source link

On Windows, the app does not quit when window is closed #57

Closed strogonoff closed 4 years ago

strogonoff commented 5 years ago

This seems to be related to a situation where a promise is being processed (e.g. repo data fetched) when user closes all windows, similar thing seems to happen during relaunch sequence e.g. when app data is cleared during troubleshooting.

strogonoff commented 5 years ago

Reproduction scenario:

Launch app
Reset repository URL, which would relaunch the app and trigger fresh repository pull
After the app started again, close main window at any time
Processes will remain in Task Manager :(

ronaldtse commented 5 years ago

strogonoff commented 5 years ago

many people reported a similar issue, but generally like in this case it's caused by mistakes our app already isn't making

On 11 Nov 2019, at 9:46 AM, Ronald Tse notifications@github.com wrote:

Related to this? https://stackoverflow.com/questions/52105917/electron-windows-app-close-not-ending-threads

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or unsubscribe.

ronaldtse commented 4 years ago

Tested, not occurring anymore.