Git password prompt: clarify what value to enter if GitHub 2FA is enabled

ituob / itu-ob-editor

Cross-platform desktop application for collaborative editing of ITU Operational Bulletin data

6 stars 3 forks source link

Git password prompt: clarify what value to enter if GitHub 2FA is enabled #61

Open ronaldtse opened 4 years ago

ronaldtse commented 4 years ago

If GitHub two factor authentication is enabled, the password prompt will keep being prompted without explaining why.

The workaround is to go to GitHub Settings > Personal Access Token and generate one with “repo” functionality to be able to make the pushes.

If the editor app detects that two factor is enabled, it should prompt the user to create a password access token.

strogonoff commented 4 years ago

To work around the password requirement, the options are:

Request to create a personal token like suggested in the description
Allow to specify SSH key, if Git is installed locally it may be possible to make work, but not certain
Support OAuth (this is the least certain way from previous experience)

strogonoff commented 4 years ago

I’m going to go with the personal access token for now.

By the way, the app may not be able to tell if authentication error is due to 2FA or wrong password. This will be made part of the docs, to which password prompt should link.

strogonoff commented 4 years ago

I’m not a fan of tying our app to GitHub, it’s meant to support any Git implementation. Additionally, 2FA means potentially supporting integrations with multiple Git hosting provider APIs in future, which may be overhead we’re unable to bear yet.

No objection to documenting GitHub-specific issues like this one, though.