ituob / itu-ob-editor

Cross-platform desktop application for collaborative editing of ITU Operational Bulletin data
6 stars 3 forks source link

Error building on GHA (GH_TOKEN related) #72

Closed strogonoff closed 4 years ago

strogonoff commented 4 years ago

Error building ITU OB Editor on GHA, about GH_TOKEN. I believe we should add it in repo secrets[0]? I added mine, but it doesn’t work. Feel free to remove it.

[0] https://github.com/electron-userland/electron-builder/issues/1693#issuecomment-380408619

strogonoff commented 4 years ago

I suppose GH_TOKEN I added would not work because I am not the owner of the repository, so perhaps @ronaldtse you could add the appropriate GH_TOKEN. I removed the token I added trying to troubleshoot it.

(It’s not related to signing, but to publishing built release. I will reinstate signing once we have build working otherwise on GHA.)

ronaldtse commented 4 years ago

Fixed!