Fix BACKUP_ON_STARTUP with ONE_SHOT=true

itzg / docker-mc-backup

Provides a side-car container to backup itzg/minecraft-server world data

https://hub.docker.com/r/itzg/mc-backup

MIT License

332 stars 52 forks source link

Fix BACKUP_ON_STARTUP with ONE_SHOT=true #199

Closed wyne closed 3 months ago

wyne commented 3 months ago

Fix compatibility issue where setting BACKUP_ON_STARUP=false will disable ONE_SHOT backups; introduced in #198
Add tests to capture combinations of BACKUP_ON_STARUP and ONE_SHOT

To fix:

[ ] Replace sleep method waiting for backup with another approach

wyne commented 3 months ago

@itzg Sorry, I found a bug with my last PR. It's a simple fix, but I also contributed some robust testing for it. I can make a smaller PR if you'd prefer the fix without my large test file.