itzg / docker-minecraft-server

Docker image that provides a Minecraft Server that will automatically download selected version at startup
https://docker-minecraft-server.readthedocs.io/
Apache License 2.0
9.23k stars 1.52k forks source link

Microsoft/Mojang has modified the world types requiring modification of docker image #1445

Closed finndo77 closed 2 years ago

finndo77 commented 2 years ago

Describe the problem

it looks like Microsoft/Mojang has made a change to the name of the default world generation type, this causes a warning/error during startup

[17:41:42] [ServerMain/WARN]: Failed to parse level-type default, defaulting to minecraft:normal
[17:41:43] [Server thread/INFO]: Starting minecraft server version 22w12a

Container definition

#! /bin/bash

echo "starting up Snapshot server"
docker run -d\
  --name mc119\
  -e OVERRIDE_SERVER_PROPERTIES=true\
  -e UID=1000\
  -e GID=1000\
  -e INIT_MEMORY=2G\
  -e MAX_MEMORY=16G\
  -e VERSION=snapshot\
  -e EULA=TRUE\
  -e ENABLE_RCON=true\
  -e RCON_PORT=25575\
  -e OPS=BGFuryk\
  -e MOTD='Minecraft 1.19!'\
  -e PVP=true\
  -e SPAWN_PROTECTION=4\
  -e SIMULATION_DISTANCE=6\
  -e VIEW_DISTANCE=18\
  -e NETWORK_COMPRESSION_THRESHOLD=128\
  -e PLAYER_IDLE_TIMEOUT=60\
  -e ONLINE_MODE=true\
  -e MAX_WORLD_SIZE=18000\
  -e MODE=survival\
  -e FORCE_GAMEMODE=true\
  -e DIFFICULTY=hard\
  -e MAX_BUILD_HEIGHT=320\
  -e SERVER_NAME=mc119\
  -e LEVEL=mc119\
  -e MAX_PLAYERS=25\
  -e SPAWN_ANIMALS=true\
  -e SPAWN_MONSTERS=true\
  -e SPAWN_NPCS=true\
  -e ALLOW_NETHER=true\
  -p 25565:25565\
  -v /mnt/minecraft-2/mc119:/data\
  -v /etc/timezone:/etc/timezone:ro\
  itzg/minecraft-server:java17

exit

Container logs

[17:41:42] [ServerMain/WARN]: Failed to parse level-type default, defaulting to minecraft:normal
[17:41:43] [Server thread/INFO]: Starting minecraft server version 22w12a
finndo77 commented 2 years ago

I do not get this on my 1.18.2 server, so will be be for future versions only

finndo77 commented 2 years ago

current read me file info on world gen types:

Level Type and Generator Settings
By default, a standard world is generated with hills, valleys, water, etc. A different level type can be configured by setting LEVEL_TYPE to an expected type, for example

DEFAULT
FLAT
LARGEBIOMES
AMPLIFIED
CUSTOMIZED
BUFFET
BIOMESOP (Biomes O' Plenty for 1.12 and older)
BIOMESOPLENTY (Biomes O' Plenty for 1.15 and above)
finndo77 commented 2 years ago

also, note that I am aware some of the lines in my docker start script are unnecessary, they are there, because there are other servers where I set different values to those lines and I leave them in for consistency across all my deployments.

itzg commented 2 years ago

Sounds like eve their README is not updated with the change. Noted for future work.

finndo77 commented 2 years ago

I noticed, I tried to find some documentation to link for it.

On Mon, Mar 28, 2022, 8:28 AM Geoff Bourne @.***> wrote:

Sounds like eve their README is not updated with the change. Noted for future work.

— Reply to this email directly, view it on GitHub https://github.com/itzg/docker-minecraft-server/issues/1445#issuecomment-1080588958, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE57HK65ZIBVELVZFSRIOLVCGQU3ANCNFSM5RX6QJHA . You are receiving this because you authored the thread.Message ID: @.***>

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 30 days with no activity. Please add a comment describing the reason to keep this issue open.

Xanthrum commented 2 years ago

do u know how to fix this?

itzg commented 2 years ago

What's strange is their own default server.properties has the wrong/old value.

@Xanthrum there's nothing to fix other than setting the existing LEVEL_TYPE env variable to one of https://minecraft.fandom.com/wiki/Server.properties#level-type

Xanthrum commented 2 years ago

okay but then it should work right? even with an 1.19 server?

itzg commented 2 years ago

Now that I see it is Mojang's bug, I think I'll close this issue. I could have the script default LEVEL_TYPE to minecraft:normal, but that goes against my philosophy to overwrite as few properties as possible with the default container config.

@finndo77 please re-open if you disagree.

@Xanthrum yes, there's no bug here.

itzg commented 2 years ago

...and I'll re-open, because I see the original point about the README in this repo is wrong.