search

itzg / minecraft-server-charts

MIT License
267 stars 142 forks source link

Add support to see namespace when performing --dry-run #212

Closed ryanchauvin closed 6 days ago

ryanchauvin commented 2 months ago

Added support to see namespace in yaml files when performing --dry-run for all charts.

ryanchauvin commented 2 months ago

https://github.com/itzg/minecraft-server-charts/issues/210

itzg commented 2 months ago

Oh yeah, rcon web admin is broken for some reason. You might need to revert your changes for that chart unless you feel like investigating 😄

ryanchauvin commented 2 months ago

I can look into it, I just sent you an email for more details around the issue.

From: Geoff Bourne @.> Sent: Sunday, June 9, 2024 7:28 PM To: itzg/minecraft-server-charts @.> Cc: Ryan Chauvin @.>; Author @.> Subject: Re: [itzg/minecraft-server-charts] Add support to see namespace when performing --dry-run (PR #212)

Oh yeah, rcon web admin is broken for some reason. You might need to revert your changes for that chart unless you feel like investigating 😄

— Reply to this email directly, view it on GitHubhttps://github.com/itzg/minecraft-server-charts/pull/212#issuecomment-2156925086, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEWISGGM7UBYVI64BDQKSD3ZGTXJBAVCNFSM6AAAAABJA7LKVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJWHEZDKMBYGY. You are receiving this because you authored the thread.Message ID: @.***>

itzg commented 1 week ago

It's still reporting merge conflicts

image

toddejohnson commented 6 days ago

It looks like the helm chart is struggling and I don't see this field in values.yaml:

Helm upgrade failed for release mc/mc1 with chart minecraft@4.22.1: template: minecraft/templates/extraports-svc.yaml:10:24: executing "m
inecraft/templates/extraports-svc.yaml" at <.Release.Namespace>: nil pointer evaluating interface {}.Namespace

I'm already targetNamespace: mc in kind: HelmRelease. Do I need to be more blunt with it?

itzg commented 6 days ago

@toddejohnson please try out this chart release

https://github.com/itzg/minecraft-server-charts/releases/tag/minecraft-4.22.2

toddejohnson commented 6 days ago

Applied without issues. Thank you for the quick fix @ryanchauvin!!!

Whew I was sweating for a bit as I don't know how to get Flux to reference a git tag helm chart. I saw it published to the normal URL and it has applied without issues.

ryanchauvin commented 5 days ago

Sorry for the oversight, glad it’s working now 😊

Get Outlook for iOShttps://aka.ms/o0ukef

From: Todd Johnson @.> Sent: Friday, August 30, 2024 4:36:57 PM To: itzg/minecraft-server-charts @.> Cc: Ryan Chauvin @.>; Mention @.> Subject: Re: [itzg/minecraft-server-charts] Add support to see namespace when performing --dry-run (PR #212)

Applied without issues. Thank you for the quick fix @ryanchauvinhttps://github.com/ryanchauvin!!!

Whew I was sweating for a bit as I don't know how to get Flux to reference a git tag helm chart. I saw it published to the normal URL and it has applied without issues.

— Reply to this email directly, view it on GitHubhttps://github.com/itzg/minecraft-server-charts/pull/212#issuecomment-2322370915, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEWISGFU2YPBBSBNQWM6JG3ZUDQXTAVCNFSM6AAAAABJA7LKVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRSGM3TAOJRGU. You are receiving this because you were mentioned.Message ID: @.***>