iv-org / invidious

Invidious is an alternative front-end to YouTube
https://invidious.io
GNU Affero General Public License v3.0
16.47k stars 1.86k forks source link

[Enhancement] Add video title and channel to hash of /watch? links #5006

Closed mk-pmb closed 1 month ago

mk-pmb commented 1 month ago

Is your enhancement request related to a problem? Please describe. For the past few weeks, my favorite instances often have trouble generating the video details page because of "Please sign in" / "This helps to protect […]". My usual procedure is:

However, now that all the tab titles are just "Error", that last step needs manual cross-checking and thus has become very tedious.

Describe the solution you'd like Since the list pages are still able to show title and channel, let's append a length-limited, URL-encoded version of both as a hash (#) part of the link URL. Example: /watch?v=cUBz04LlLVk could become /watch?chan=Veritasium&v=cUBz04LlLVk#title=Seeing+Inside+A+Thermite+Reaction (My donwload queue editor can auto-parse that on paste.)

As an optional next step, we could even use that to improve the in-browser tab title and error page display for users who have JavaScript enabled. However, that is not a priority for me.

Describe alternatives you've considered

Additional context

unixfox commented 1 month ago

Not entirely sure if we want to differ from how youtube watch page URL works.

Since some people may just change the invidious domain by www.youtube.com to go to youtube. They will then send these additionnal parameters that youtube servers doesn't know about.

This should be relatively harmless but it's one thing that may distinguish the user from the others if there are some unknown parameters in the URL.

I don't have an exact opinion on this. Why not but I feel like this could have bad consequences that we don't know about. Maybe this could be configurable with a parameter.

Anyway sounds like a pretty simple task to do in crystal if you want to try. As maintainers we will never have the time to work on this, just so you know.

mk-pmb commented 1 month ago

As maintainers we will never have the time to work on this, just so you know.

Thanks for clarifying that! Then I'll try and make it a hidden feature, activated by a secret cookie, as part of #2837.