search

iv-org / invidious

Invidious is an alternative front-end to YouTube
https://invidious.io
GNU Affero General Public License v3.0
16.02k stars 1.76k forks source link

Video keybinds. #974

Open mini-eggs opened 4 years ago

mini-eggs commented 4 years ago

Hi. Love the site. I would like to start a conversation on possible video keybinds that could be implemented. I could submit a PR for everything I mention if interested.

YouTube has some alright keybinds. Left/right to skip back/ahead a few seconds. Up/down for audio. Among others. I'd like to implement this for Invidio along with both an emacs mode and vim mode (placed https://invidio.us/preferences ?). Would a PR for this be accepted? Any other keybinding suggestions?

PoepiePeppie commented 4 years ago

invidio.us already has the same keybinds as youtube. k to pause, j and l to skip 10 seconds and the arrows to skip 5 seconds.

mini-eggs commented 4 years ago

@SugoiSheep I would like more. For a possible vi mode I'm thinking of these (I'm not set on any of these in particular, off the top of my head):

Not expecting any maintainer or contributor to grant my every wish. Wanting to make sure there's interest in this before I begin a PR. Happy to write the code needed for an emacs/vi mode on Invidious.

grahamperrin commented 4 years ago

Thanks

Playback speed

I prefer the single keystrokes that are available (with YouTube) through the YouTube Playback Speed Control extension.

Audio

For predictability and consistency, I suggest using the volume keys that are used at YouTube.

Generally

A single stroke – not requiring two-key combinations – is hugely beneficial when transcribing. For example, with a text file in one window and original AV content in a separate window:

  1. transcribe
  2. hear a difficult segment
  3. Alt-Tab
  4. ← - - ↑ ↑
  5. Alt-Tab
  6. easier transcription of the previously difficult segment (slower, louder)

… and so on.

Reference

Keyboard shortcuts for YouTube - YouTube Help

nathgit commented 4 years ago

There's an extension called Vimium that creates shortcuts for ALL websites. you can disable any or all shortcuts for any site as well as customize them.

ssokolow commented 4 years ago

I came here expecting to have to file a feature request for ← and → keybinds because they weren't doing anything.

It turns out, they have no effect if the Play/Pause button has focus.

(I habitually click the Play/Pause button rather than ever clicking the main body of videos because, on YouTube's normal player, Play/Pause will respond instantly or nearly instantly, while, with a bogged-down browser, clicking bare video could take 10+ seconds to respond.)

mini-eggs commented 4 years ago

@ssokolow

This is something I believe a future keybinds feature should address. YouTube does a great job in putting the user's focus on the correct element at the right time (... but not 100% of the time). For example, when a user on Invidious clicks on the fullscreen button the video will fullscreen - but the fullscreen button will still retain focus... This isn't great, as later the user may press spacebar thinking the video will pause and instead the video exits fullscreen.

Once again, I'm happy to craft a PR for what I've mentioned so far - but I want assurance the maintainers would be willing to accept such features before sinking time into it.

@nathgit

Vimium is good but is restricted by how Chrome treats extensions. For example, a Vimium user can't close a tab with Vimium keybinds in a tab that is only displaying an image (e.g. URL is https://example.com/item.png) and is currently loading the image. This is a Chrome restriction.

For readers interested in what nathgit brings up, Qutebrowser is pretty dang good.

@grahamperrin

There could be a YouTube mode. What I've been thinking about is a keybinds select that'll live on https://invidio.us/preferences with several values: Emacs mode, Vi mode, YouTube mode, etc. You can probably find parallels of the YouTube keybinds list and what I've mentioned above. I was referencing that YouTube keyboard shortcut doc while crafting my earlier comment.

grahamperrin commented 4 years ago

Nit: the current defaults + and - overlap/conflict with sizing of closed captions/subtitles. A few frames from a screen recording:

cinema, 1 75

full, 1 75

full, 2 0

It doesn't bother me (I do often rely upon subtitles), might bother someone else but honestly I don't think it's enough of a bother to change the current defaults. + and - are intuitive, memorable.

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, you just have to post a comment and it will be unmarked.

syeopite commented 3 years ago

Bump

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, you just have to post a comment and it will be unmarked.