Closed ivandokov closed 11 months ago
@ivandokov I personally don't think that removing empty directories should be tied to the move flag, because not all users may want this to be done by default. For example, I used to organize my photos by category (trip name) and no photo organization software (not the best idea since some photos don't fall under a category, and some fall under multiple categories). However, using Phockup I am able to organize my photo library by date and then use an external photo management tool like Shotwell (https://wiki.gnome.org/Apps/Shotwell) to categorize certain groups of photos. I find it useful that Phockup does not automatically remove directories without the user's consent when moving (instead of copying) files, because that way the folder names (and trip names) are still there so that I am able to easily categorize photos with a new photo management tool.
This will happen only when the directory is empty. I don't see how the empty directory is of any use even in your case. You don't know where the photos came from when you are moving them. Please correct me if I'm wrong.
For the case as @riyaadazad describes: if a directory is called '2018_july_trip_to_spain', seeing the empty directory indicates that the user still needs to go into e.g. Shotwell and tag/annotate some 2018/07 photos as the 'trip to Spain'. So seems useful to leave as reminder.
When the process strategy is changed to move (
-m|--move
) the script should check if the source directory for any remaining file and if there are none the directory should be deleted.This could be done for each subdirectory after each file move process (could be expensive operation) or at the end of the whole process.