ivanleekk / pe

0 stars 0 forks source link

same tele handle can get added to multiple ta #6

Open ivanleekk opened 10 months ago

ivanleekk commented 10 months ago

since a tele handle can only point to one account, each tele handle should be for only 1 person. thus if the same tele handle were to be added to multiple people, an error should appear

to reproduce:

  1. add n/abcd p/12345 e/abcde@abcde.com tele/@abcde

  2. add n/qwerty p/54321 e/qwerty@qwerty.com tele/@abcde

expected: some kind of error that the same tele handle has been added before actual: no issue, 2nd person gets added

soc-se-bot commented 10 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Able to add TAs with different names, yet the same for other attributes.

Screenshot 2023-11-17 at 4.35.19 PM.png

From the above screenshot, index 13 and 14 have the same fields, but different names. Given that their phone numbers / telegram handle / email addresses are the same, it would make sense that this should not be allowed, as TAs should not just have different names, they should by right have different phone numbers, telegram handles and email addresses as well.


[original: nus-cs2103-AY2324S1/pe-interim#4711] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

The same issue of how we check duplicates. We have to properly define how we handle duplicates.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]