fix: make tool work on Windows

LoremFooBar commented 4 years ago

First of all, thanks @ivanparvaresh for you effort in making this tool! I am happy I was able to find it. Unfortunately, the tool did not run for me on Windows. This PR aims to fix it. Would appreciate your review and any comments.

The problem was that the Executor always executed commands with -c as the command option. This works with /bin/bash but not with cmd.exe on Windows.

add Entrypoint class
change DefaultEntrypointDetector to return Entrypoint
use command option from Entrypoint class in Executor
make sure current configuration json does not need to change - no changes made to serialization

LoremFooBar commented 4 years ago

Thanks for merging. I'd be happy to help with cross platform tests, I suppose we can discuss it in an issue.

ivanparvaresh commented 4 years ago

Thanks for merging. I'd be happy to help with cross platform tests, I suppose we can discuss it in an issue.

Thank you for your great PR, I have already created an issue for that #32, feel free to look at that, 👍

ivanparvaresh / dotnet-exec

fix: make tool work on Windows #30