search

ivylabs / suitecrm-analytics

4 stars 4 forks source link

"Average Call Duration" Report - Cells in the Results table do not render if no data is found, rather than "0m" #286

Closed johnM2401 closed 3 years ago

johnM2401 commented 3 years ago

Describe the bug When viewing the Average Call Duration Report, if a cell would have no data, it does not render the Cell itself rather than showing something like "0m"


**Component What component does this bug relate to?

  1. Report - Average Call Duration


**Solution File AverageCallDuration.prpt


To Reproduce Steps to reproduce the behavior:

  1. In the CRM have Call Data for One or Two of: Leads / Cases / Opportunities, for a Month. (But not for all 3)
  2. Run the ./run script to push this to the DWH
  3. View the "Average Call Duration" report, and set the Call From/Call To Parameters to allow your data to show.


Expected behavior If a Cell would have no Data, (or 0minutes), the Cell instead does not render


Screenshots image


Desktop (please complete the following information):

harrisward commented 3 years ago

@johnM2401 Good spot. This is now fixed. Once its tested I will merge into master

Feature Branch: https://github.com/ivylabs/suitecrm-analytics/tree/feature-286 Pull Request: https://github.com/ivylabs/suitecrm-analytics/pull/288

johnM2401 commented 3 years ago

Hey @harrisward Is this good to go for me to test?

I've given it a go on the most recent master, but seems to be the same issue. image

Unless you want me to test this independently from the master branch?

johnM2401 commented 3 years ago

Hey @harrisward

Wasn't sure if you did indeed want me to have a look by pulling the feature-286 branch seperately, but I did so and it looks to be fine: image

Would be worth merging into master to test alongside the rest of the work, though.