Closed johnM2401 closed 3 years ago
@johnM2401 Added an order by clause to keep the database sorted correctly and set the bar / line chart to stacked = false based on Fridays discussion.
Feature Branch: https://github.com/ivylabs/suitecrm-analytics/tree/feature-289 Pull Request: https://github.com/ivylabs/suitecrm-analytics/pull/290
Hey @harrisward,
Like #286, Wasn't sure if you wanted me to take a look at this separate from the Master branch, but I have had a look. Looks much better, able to differentiate the chart bars much easier.
However, one minor point of Feedback I have is that the Order of the bars does not match the Order of the columns
ie, The Chart bars are ordered: Leads - Opportunities - Cases Whereas the Report tables are ordered: Leads - Cases - Opportunities
I think it would be worth making these two match, for easier readability for users.
What are your thoughts?
@johnM2401 I've reorder the columns to Cases, Leads and Opportunities.
Merged the code to the master branch
Hey @harrisward
Pulled latest master. The Bars do seem to be ordered differently, but don't seem to be Cases->Leads->Opportunities
They now appear to be Opportunities->Cases->Leads
Can you make sure you have refreshed everything? When I build from master I get the following:
Hey @harrisward
So, I do see that order when using Demo Data:
However, the order appears to be different using Live Data:
Hi @johnM2401 I've tried everything I can to recreate the issue my side including manually forcing the chart data but I can't reproduce the issue you are seeing. Im sure you have already tried but my only suggestion is to rebuild the whole server to make sure no caching exists anywhere. The latest output I get is in the screenshot below:
Because of this im going to put this ticket into backlog and take it out of the 1.4 release
Hey @harrisward
hmmmm I typically rebuild the full server whenever I pull down from master, so it should be fairly cache-free
However, it seems like the chart may be cached to some extent in your screenshot? (Unless i've misread it?)
When I have the parameters: Call Period From: 2021-07 Call Period To: 2021-07
This is all I see:
I don't believe I have any Call Data from 2019, as these are the options I have for parameters:
Where it looks like your chart is displaying a bunch of data from 2019
But, to confirm, this is what I see after a full re-build:
@johnM2401 Thats okay its not cached. The data in the chart is not related to any real or demo data. Its is a dummy dataset to test the output of the chart if certain data is sent to it. I recreated the same structure as your dataset and got the results you see before.
As this is aesthetic im not too worried for fixing it in this release
Quick Note Quick Note after our call at Fri 18th Jun, 1pm As we are toggling the "Stacked" option for these charts, this issue may no longer be viable. (Will depend on how the Bars generate after stacking is disabled)
Describe the bug On the Average Call Duration report, the Stacked Bar Chart appears to render inconsistently, depending on the Date Parameters used.
It appears as though the 3 Segments can render in a different order, with what seems to be no consistency/pattern
I understand why this is occurring, as the order appears to be dependant on the returned Data. However, after discussing with Ross/Evan, we agreed it would be good if this was consistent, if possible, for user experience.
See screenshots for examples.
**Component What component does this bug relate to?
**Solution File AverageCallDuration.prpt
To Reproduce Steps to reproduce the behavior:
Expected behavior The Same order/Colours are associated to the Segments/Modules, on the Stacked Bar
Screenshots ie, If I do March-March, with my Dataset:![image](https://user-images.githubusercontent.com/13675281/122555256-f78b2b80-d031-11eb-9bad-1acb0e0339bc.png)
The Largest segment, (Leads), is in the centre.
However, if I change the Date Parameters to March-May, the Largest Segment, (Leads), is at the bottom (Both Segments are associated to Leads)![image](https://user-images.githubusercontent.com/13675281/122555331-125da000-d032-11eb-96e6-e3c6237a8b84.png)
And If I choose March-July, the Largest Segment, (Leads), is at the top:![image](https://user-images.githubusercontent.com/13675281/122555469-3f11b780-d032-11eb-95ee-a17001fd897e.png)
While not a major functionality issue, I feel the inconsistency may be misleading/confusing to some users.
Desktop (please complete the following information):