search

ivylabs / suitecrm-analytics

4 stars 4 forks source link

Periodic Agent Country Sales Report - Columns showing when no Data returned. #295

Closed johnM2401 closed 3 years ago

johnM2401 commented 3 years ago

Describe the bug When the Periodic Agent Country Sales report would show 0 results, it appears to show some of the Columns, rather than simply just "No Data Available"

**Component What component does this bug relate to?

  1. Report - Periodic Agent Country Sales report

**Solution File PeriodicAgentCountrySales.prpt

To Reproduce Steps to reproduce the behavior:

  1. Navigate to the Periodic Agent Country Sales Report
  2. Set parameters so that 0 data is returned
  3. View the "No data available" screen

Expected behavior Like other reports, there should be no Columns shown on the Report when no data is returned

Screenshots image

Desktop (please complete the following information):

harrisward commented 3 years ago

Added logic to hide this row when no data is returned

harrisward commented 3 years ago

Feature Branch: https://github.com/ivylabs/suitecrm-analytics/tree/feature-295 Pull Request: https://github.com/ivylabs/suitecrm-analytics/pull/296

harrisward commented 3 years ago

Please use the feature branch https://github.com/ivylabs/suitecrm-analytics/tree/feature-295. Once the fix has been confirmed I will merge the report into master @johnM2401

johnM2401 commented 3 years ago

Hey @harrisward Looks good: image

Can be merged into master.