iyxan23 / zipalign-java

zipalign implemented as a java library with 0 deps
MIT License
53 stars 13 forks source link

page-align uncompressed .so files #5

Closed jpstotz closed 9 months ago

jpstotz commented 1 year ago

Thanks for providing a Java implementation of zipalign.

From my perspective it looks quite good, it only misses the possibilities to align .so files by 4096 instead of default 4.

This options is becoming more and more important as recent Android Gradle plugin versions automatically set extractNativeLibs=false which means they are no longer extracted from the APK file upon installation, but directly used from within the APK. For doing so it is required to store the .so files uncompressed and align them to page boundaries (4096), independent of the value the other files are aligned to.

iyxan23 commented 1 year ago

Hi!

I have been thinking about adding this feature, but haven't got the time for it and it's a bit difficult to do it with the current system. It's just adding a special case for .so files to align it by 4096, right? I'll try to do it whenever possible, thanks for the reminder.

Update: sorry I'm really busy recently, I'm not sure when I'm going to be able to invest my time re-architecting the system. anyway, thanks for the interest!

hais1992 commented 10 months ago

I also need it very much. I hope the author has time to upgrade it. Thank you very much

iyxan23 commented 9 months ago

I'm happy to share that aligning .so files will land on 1.1.0. I had just implemented in in the branch so-align. Thanks guys!