iza-institute-of-labor-economics / gettsim

The GErman Taxes and Transfers SIMulator
https://gettsim.readthedocs.io/
GNU Affero General Public License v3.0
54 stars 32 forks source link

BUG: Mostly replace `eink_st` / `soli_st` by `lohn_st` / `soli_st_lohnst` #606

Open hmgaudecker opened 1 year ago

hmgaudecker commented 1 year ago

Bug description

We have been using eink_st / soli_st to get at proxies for net income in several places.

Probably this should change to a combination of lohn_st / soli_st_lohnst as this is what is actually considered in many cases.

However, things may need a different treatment if income other than from dependent employment is around. Sometimes there will be a complete regime change, e.g., for Elterngeld the reference period changes from a 12-months window before birth to the calendar year before birth.

hmgaudecker commented 1 year ago

Just stumbled across this in grunds_im_alter, but will be relevant in many other locations. Best search for eink_st.

hmgaudecker commented 1 year ago

@JakobWegmann, would be great if you could weigh in here.

Often, the strategy will likely be to have an input column with relevant net income from the previous year and giving people advice on how to generate it if they have the previous year's data.

JakobWegmann commented 1 year ago

I think eink_st / soli_st should be replaced by lohn_st / soli_st_lohnst in the following functions:

arbeitsl_geld_eink_vorj_proxy_m elterngeld_nettolohn_m wohngeld_eink_vor_freib_m_mit_elterngeld arbeitsl_geld_2_eink_m grunds_im_alter_eink_m

This is quite a substantial change, so it would be good to have many solid test cases, optimally also spanning the last years.