search

izelnakri / eth

Ethereum utilities for Elixir
MIT License
119 stars 44 forks source link

Update wallet.ex #68

Closed berg95 closed 2 years ago

berg95 commented 2 years ago

Implemented use of pipes

izelnakri commented 2 years ago

Hi @berg95 , thank you for taking the time to contribute.

I don't see any benefits of this change, please describe it in the pull request. Otherwise I'll close the PR in few weeks.

berg95 commented 2 years ago

Hello! I'm not sure if you have any standard format you like to implement in your project. But my change is merely a readability improvement in my opinion.

izelnakri commented 2 years ago

Thanks for your response. I find readability improvement proposed here is subjective and I actually disagree with this change, thus I'm closing this PR.