izzyreal / mpc

mpc2000xl emulator static library
GNU General Public License v3.0
73 stars 8 forks source link

Random crash in step editor #146

Closed messeraffe closed 1 year ago

messeraffe commented 1 year ago

I tried to reproduce it but the crash seems to be random:

image

Crash report: 20230325_crash.txt

izzyreal commented 1 year ago

I tried the same setup but with Chrome browser playing https://jungletrain.net/shows. So far it looks very stable.

What I did notice is that VMPC2000XL doesn't like the fact that the .ALL file you gave me earlier has a track with no name. How did you create the file? Does it come straight from the MPC2000?

messeraffe commented 1 year ago

Initially I created it on the MPC 2000, yes, but VMPC2000XL was throwing an error when trying to load it. If I remember correctly I then exported the .MID file from the 2000 and then later created the .ALL file from within VMPC2000XL

izzyreal commented 1 year ago

Sounds like a problem with VMPC2000XL MID file parsing, something that should now be fixed.

The .ALL file you have is now a bit doomed 😅 If you attach the version you need to this thread, or if you confirm the version you sent me earlier is what you need, I'll undoom it for you. Otherwise you can start from MID again. It should say "Track-01" and not have an empty track name.

messeraffe commented 1 year ago

Thanks but actually I will try to avoid all MPC 2000 data for now just to make sure I´m not introducing any more doomness into the process. Just had a situation with a 2K sample where the step editor did not move in the TC mentioned tick step rate. I will use regular WAV from now on to see how the tool behaves.

izzyreal commented 1 year ago

Ok I'll optimistically close this ticket, assuming the crash is caused by a series of undefined behaviour after loading a corrupted .ALL file. Feel free to reopen it at any time.

By the way, we could also look into gradually adding support for MPC2000 files. We'd start with SND, then PGM, then MID, ALL and APS. The SND should be relatively easy, and I think the other ones should also be largely the same as 2KXL. It would require quite a bit of back and forth communication between us, where I'd ask you to send file specimens after getting the 2000 in a specific state.

messeraffe commented 1 year ago

@izzyreal Sure, happy to support.

Not sure if this here might already give some insights or whether it´s only referring to the XL and filename length:

https://www.eigenbahn.com/2021/04/11/mpc-2000-floppy-format https://github.com/p3r7/mpc-2000-floppy-extractor

izzyreal commented 1 year ago

Thanks but those projects are about getting files out of an MPC2000 floppy (image), not about the file formats themselves.