search

jac241 / anki_killstreaks

A Halo and Call of Duty inspired add-on to gamify Anki and make reviewing more bearable
GNU Affero General Public License v3.0
17 stars 8 forks source link

Adds sounds #11

Open newageoflight opened 4 years ago

newageoflight commented 4 years ago

Added sounds for killstreaks. Hopefully this does not incur any copyright issues.

jac241 commented 4 years ago

Nice I'll take a look at this and try to merge it sometime this week. In terms of copyright, probably no worse than sharing the images?

jac241 commented 4 years ago

I'll add an option to turn sound on or off to the menu.

jac241 commented 4 years ago

Prometric cancelled my original Step 1 test date and I had to move it forward 2 weeks, so I probably will not be getting to this until after May 21 unfortunately.

newageoflight commented 4 years ago

Are you still cool to merge this into the main branch?

jac241 commented 4 years ago

Yeah I just want to add an option in the menu to toggle sound on and off. Would you be up for that or do you think you'd need me to do it?

jac241 commented 4 years ago

Have you had any thoughts about how to fix the bug with hitmarkers? I was thinking initially we could check to see if that add-on was installed and not enable sounds if it was. You can check to see if it is installed by scanning the add-ons directory and reading the manifest.json files in each one.

Have you tried delaying the sound start time until it would be after the hitmarker one? I am hesitant to make a release if it doesn't work with hitmarkers since that add-on is probably frequently used with killstreaks.

newageoflight commented 4 years ago

I haven't tried it with further delay than the hitmarkers or implementing sound toggle. Tbh I'm not entirely sure how to do the toggle but I'll have a crack at it.

EDIT: With the hitmarker one I actually did try implementing a longer delay than the hitmarker sound, didn't make a difference. They're all added onto the play queue anyway so all sounds should play in sequence. The ideal outcome would be for the hitmarker sound and the medal sound to play simultaneously but I haven't figured out how to do that (hence in my Anki setup at the moment, hitmarkers is disabled).

millett commented 4 years ago

oh wow i just made a janky version of this on my own and dindn't even realize this pr existed. please merge this PR when you get the chance!!

millett commented 4 years ago

re: copyright, i think this applies ( i am not a lawyer ) https://www.xbox.com/en-US/developers/rules

millett commented 4 years ago

re: bug with hitmarkers. I think you'd either have to add a delay to the sound or re-record the sounds with the hit markers on top. Kind of tedious. I think the anki media player can only play one sound at a time (not entirely sure tho)