jackbsteinberg / std-toast

120 stars 4 forks source link

Close button API naming #47

Open domenic opened 5 years ago

domenic commented 5 years ago

46 fleshes out the proposed close button API. The names there are:

We could potentially use different names here, e.g. closeable or close or dismissable or similar. We could also change the ::part() name independently from the attribute/property/showToast option name.

Thoughts welcome!

domenic commented 5 years ago

46 changed substantially before landing in a way where it seems much more obvious closeButton is a reasonable name. The only potential confusion left is that one might expect el.closeButton to return a button element, instead of the string or boolean value it's currently specified to do.

I'll leave this open in case folks have thoughts, and edit the OP to talk about the API that's in master now. But there might not be much to do here.