Open domenic opened 5 years ago
closeButton
is a reasonable name. The only potential confusion left is that one might expect el.closeButton
to return a button element, instead of the string or boolean value it's currently specified to do.I'll leave this open in case folks have thoughts, and edit the OP to talk about the API that's in master now. But there might not be much to do here.
46 fleshes out the proposed close button API. The names there are:
closebutton=""
attribute onstd-toast
, used as either<std-toast closebutton>
or<std-toast closebutton="Dismiss">
el.closeButton
JS property reflecting theclosebutton=""
attributecloseButton: true
orcloseButton: "string"
as ashowToast()
option, behaving the same as the JS property::part(closebutton) { ... }
in CSS to style itWe could potentially use different names here, e.g.
closeable
orclose
ordismissable
or similar. We could also change the::part()
name independently from the attribute/property/showToast option name.Thoughts welcome!