search

jackkoppa / cityaq

Angular PWA to compare simple air quality data for different cities, using the OpenAQ API
http://cityaq.com
7 stars 5 forks source link

fix skyline spacing issue on Firefox #1

Closed codylewis closed 6 years ago

codylewis commented 6 years ago

Small change in CSS to fix error happening solely on Firefox where margin-bottom was not being applied as intended.

Updating the spacing to padding instead of margin fixes this behavior in FIrefox while maintain functionality in other browsers.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 61.987% when pulling 48f8943a682ab58764a5ea4d14c5ceb8122e181c on codylewis:master into 4c0240a031e7360b23a3ecebdd374161860bcd81 on jackkoppa:master.

jackkoppa commented 6 years ago

Awesome, thank you @codylewis! I'll merge this in tonight, after I can merge in the changes I made for the MKEJS demo to master. This also pointed out something I need to change in the CI builds by handling permissions: pull requests shouldn't attempt to build to GitHub pages (which is why this failed), but should still run unit tests. Thanks again for catching this; looking forward to better cross-browser support

jackkoppa commented 6 years ago

Thanks again, @codylewis. Merged, and also fixed #2, so that future PRs will only trigger a sample build & unit tests. Looks great on both Firefox & Edge now 👍

codylewis commented 6 years ago

Happy to help, glad my contribution yielded more than intended! 😃