jackkoppa / cityaq

Angular PWA to compare simple air quality data for different cities, using the OpenAQ API
http://cityaq.com
7 stars 5 forks source link

Angular 6 upgrade #12

Closed jackkoppa closed 6 years ago

jackkoppa commented 6 years ago

After a few months delay, have gone through the steps required to upgrade to Angular 6. Of particular note are the required rxjs syntax & import changes, as well as the remaining issues with @angular/service-worker. Given that 504 errors still seem to occur when offline when they shouldn't, the build script that fixes those 504 errors currently remains in place.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+7.1%) to 61.751% when pulling 8a41a84a30c5362e4ada1d3a8c4eab8011c6f779 on ng-6-upgrade into fd5ed609447a8b596a7388bd73b1cdad43c43dcb on master.

jackkoppa commented 6 years ago

Successful build with Travis