search

jackkoppa / cityaq

Angular PWA to compare simple air quality data for different cities, using the OpenAQ API
http://cityaq.com
7 stars 5 forks source link

Prevent CI deploy attempts on pull requests #2

Closed jackkoppa closed 6 years ago

jackkoppa commented 6 years ago

As noticed in #1, PR's should not trigger all CI scripts (primarily the GitHub pages deployment). The deploy is properly prevented by an incorrect GitHub token variable, but this shows the build as "failing", when in fact it builds and passes unit test. Travis CI has a way to handle this with a PR variable; this should be implemented to not run deployments on PRs.

jackkoppa commented 6 years ago

Confirmed fixed w/ #3, only running build & tests, and not attempting deploy.