search

jackpoz / BotFarm

Application used to spawn WoW automated players compatible with 3.3.5a version only.
GNU General Public License v2.0
84 stars 68 forks source link

Extra Allocation in CharacterEnumeration.cs #41

Closed HelloKitty closed 7 years ago

HelloKitty commented 7 years ago

You initialize the display item array in the selection character character structure with a length of 20 but WoW only sends 19 display items for the character at the selection screen. Works fine, since read Length - 1 items but it definitely caused me an issue since I sometimes use your bot as a reference. I had to peak into Trinitycore to see why it wasn't working when reading 20 items for my own libraries.

jackpoz commented 7 years ago

got a line ?

Edit: https://github.com/jackpoz/BotFarm/blob/master/Client/World/CharacterEnumeration.cs#L27

HelloKitty commented 7 years ago

@jackpoz Yea that line, it's not too important but it definitely confused me for a tiny bit as to why only 19 character screen display items were coming down on my end lol.