search

jacktasia / dumb-jump

an Emacs "jump to definition" package for 50+ languages
GNU General Public License v3.0
1.57k stars 149 forks source link

faust definition is sometimes not found #60

Closed magnetophon closed 8 years ago

magnetophon commented 8 years ago

A while ago I added faust to the supported languages.

Sometimes dumb-jump finds multiple definitions ( which is to be expected), without the correct one included.

Unfortunately, I have not yet been able to find out under which conditions this happens.

jacktasia commented 8 years ago

Thanks for reporting this. If you can provide an example file(s) that illustrates this issue then I would be more than happy to take a look and try to fix it.

magnetophon commented 8 years ago

Great, thanks!

git clone https://github.com/magnetophon/CharacterCompressor.git emacs CharacterCompressor/CharacterCompressor.dsp

Then try to jump to the definition of gainHiShelfCrossfade. It is not found, even though it's in the same file on line 93.

Definitions in faust are really simple to find: it is the only place where the symbol = is used.

The only little snag: you can import files, either with a relative path, or implicitly via the path in $FAUST_LIB_PATH. Of course the current implementation ignores imports.

jacktasia commented 8 years ago

This will be available via MELPA in ~12 hours. Please re-open if you notice an issue, but my fix worked for your example.

jacktasia commented 8 years ago

Looks like it's on MELPA now.

magnetophon commented 8 years ago

Many thanks!