search

jacobobryant / platypub

A publishing platform built with Biff
MIT License
65 stars 13 forks source link

Add subscribers page #29

Closed jeffp42ker closed 2 years ago

jeffp42ker commented 2 years ago

I need this page so I implemented it, what do you think?

  1. Subscribers seems to naturally fit under Newsletters much like Sites View, Preview etc.
  2. Members list limit is hard-coded to 1000, default is 100. No pagination yet implemented.
  3. Only lists Subscribed members. Unsubscribed members would be a separate request to support.
  4. 2 & 3 can be overridden with query-params on GET subscribers
  5. Uses and displays the joinedAt value; the href and referrer attributes are retrieved but not displayed.
  6. Joined date display uses util/format-date which is UTC instead of local date time.

subscribers-animation-2

jacobobryant commented 2 years ago

Perfect, thanks for doing this! I've been wanting this page too, especially after realizing that the mailgun page doesn't sort subscribers by join date (I'm not sure if they even store join date on their end...).

jeffp42ker commented 2 years ago

Yeah, it's a little surprising to see that we need to supply all time-related variables in the custom variables map. They don't want to get into the business of supporting time issues I guess.

jeffp42ker commented 2 years ago

Thanks for making the code so simple and easy to follow. I didn't need to make many decisions, just follow the good examples already there. It's enjoyable to work with.