jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
429 stars 24 forks source link

Saving lyrics doesn't work for audio files from network shares #159

Closed eremem closed 1 year ago

eremem commented 2 years ago

I access my audio file from a NAS via a Windows network share (eg. \\nas01\Multimedia\Audio....). The lyrics are shown in the panel but not being saved neither to the album's directory nor as tags. If I choose some local directory, everything works as expected.

craigo- commented 2 years ago

I can confirm the exact same symptoms here. This occurs when the save directory is set to "Save to the same directory as the track" (NB: not the default setting).

When the save directory is set to "Save to the configuration directory" (the default), lyrics are successfully saved locally (in my case, to "%appdata%\foobar2000\lyrics").

To try and track down the problem I turned on "Debug logging enabled", but cannot locate where this log is saved. Can you tell me where it is?

Environment:

jacquesh commented 2 years ago

To try and track down the problem I turned on "Debug logging enabled", but cannot locate where this log is saved. Can you tell me where it is?

It's not saved anywhere by default but you can view the log from the fb2k menus in View -> Console

craigo- commented 2 years ago

Thank you. The relevant debug lines are as follows:

INFO-OpenLyrics: Saving lyrics to a local file...
INFO-OpenLyrics: Save file name format '[%tracknumber%] [%title%]' with directory class 'TrackFileDirectory' evaluated to 'file://\\homenas01\music\The Psychedelic Furs\Mirror Moves\01 The Ghost In You'
ERROR-OpenLyrics: Failed to save lyrics to Local files: Invalid path syntax
jacquesh commented 1 year ago

fyi this is fixed for v1.3 (the next release) but until that's released, the following workaround should get it working:

Map the network share as a network drive (so that Windows assigns it a drive letter) and then add the mapped drive path to your library (instead of the network share path, the one starting with "\...").