search

jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
429 stars 24 forks source link

[Feat] Manual Save - Allow user to decide whether to save lyrics on the fly #160

Closed hermit99 closed 2 years ago

hermit99 commented 2 years ago

Currently there are 4 options in Autosave config: Always, Only synced lyrics, Only unsynced lyrics, Never.

May I suggest we add an Ask option which gives back the the decision to end users whether to save the searched lyrics to local files or not. Then add a Save button on OpenLyrics Panel to save the lyrics locally when clicked.

This requested feature is a work-around that when users are playing some instrumental music, the plugin may search and return lyrics of songs having the same name, which doesn't make sense as well as messes the users' file system.

Thank you!

jacquesh commented 2 years ago

This is already supported. Set autosave to never, manually save from the lyrics panel context menu when you want to save.

You can also already mark tracks as instrumental, which stops the automatic search from happening.