search

jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
450 stars 26 forks source link

"Search for Lyrics (manually)" Window - Automatically sort search results with Timestamped at the top #398

Open ngs428 opened 2 months ago

ngs428 commented 2 months ago

What right clicking on a file and selecting "Open Lyrics" -> "Search for Lyrics (manually)" the lyrics don't appear in any specific order. One then has to click on the "Is Timestamped" header twice to move the timestamped lyrics to the top. Would be quicker to have the search results already sort by this field with the timestamped lyrics at the top.

Initial Result sorting: Initial Results

Preferred Search order (sorted with timestamped at top): Sorted

jacquesh commented 2 months ago

Results are displayed by default in the order that they were received. This is intentional so that entries in the list do not move around while the search is ongoing. Imposing other other default sort order would take that way. Is that worth it to save 2 extra clicks on the occasion that you do a manual search (which we could probably also reduce to 1 extra click by reversing the default order of the timestamp column)? Eh, maybe? I'm not immediately convinced.

Also not everybody specifically wants timestamped lyrics.

ngs428 commented 2 months ago

Makes sense. Certainly different use cases for many different users. If you could change it to the first click of the “is timestamped” header makes the time stamped at the top, that would be a good move. Save some time, I would appreciate that. I assume more users use timestamped than not.

As I mentioned in #400 this is my and many people’s main method of searching. So anything to speed it up, like only showing sources you want to search and with 1 click having timestamped at the top would be great. Thank you.

drelephant commented 2 months ago

How about two checkboxes, one to enable showing timestamped and one to show non-timestamped files?

Personally I'm usually searching for timestamped lyrics. If those aren't available then I'll settle for non-timestamped.

jacquesh commented 2 months ago

I think that's a bit of a slippery slope. If we have a checkbox for timestamped, why not also for artist/album/title/source? I expect that would quickly get out of hand. Sorting is already consistently available and just sorting the interesting results to the top is largely equivalent (in the sense that you see all the results you want). Sorting also makes the fallback to non-timestamped a tiny bit simpler (because you don't have to click anything, you just keep scrolling).

drelephant commented 2 months ago

Well if it was up to me, I'd just remember the sort order and add the new incoming files in sorted order as they come in.

How about a tickbox to preserve sorting for new items?

Then people wouldn't have to click the sort header every time, with usually multiple clicks as the results populate.

I'm just spitballing a solution so I can avoid the clicks every time, and it seems I'm not the only one who would like this.