search

jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
450 stars 26 forks source link

Add description to what lyric source/type was found when bulk searching #401

Open ngs428 opened 2 months ago

ngs428 commented 2 months ago

When using the bulk downloader for lyrics, currently the screen just stated "found", but does not give any context as to what type of lyric was found or what source was used. So when the bulk scan us done, I have to go back to the lyrics and confirm each are what I am looking for. I have "Preferences" -> "Searching" set to prefer lyric type "Synced", so I assume that setting is for the bulk download and it will try to download synced files. I may be wrong there though.

Currently in Lyric Show Panel 3 v0.6, the bulk lyric process shows what source was used and if the lyric was synced or not. This is very time saving and critical info as shown below:

LSP bulk

Adding 2 more columns to the right (or maybe just one if you repurpose the "status" column) would be ideal. 1 for "Source" and "Is Timestamped?"

Bulk Search

jacquesh commented 2 months ago

Sure, in theory now that we track where lyrics came from anyway this should be fairly easy to do.

ngs428 commented 2 months ago

That would be great! Thanks!

Rexadev commented 2 months ago

Sure, in theory now that we track where lyrics came from anyway this should be fairly easy to do.

Is this data stored in foobar's folder ?

I prefer it inside Lyrics as tags

jacquesh commented 2 months ago

Is this data stored in foobar's folder ?

Yes, it's another metadb.

I prefer it inside Lyrics as tags

Yes you've said this before. Please put together a detailed proposal or a complete and functional pull request instead of spamming unrelated issues. Marking this as off-topic here.