jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
450 stars 26 forks source link

letras.com search returns bogus lyrics #408

Open H2Swine opened 2 months ago

H2Swine commented 2 months ago

Steps to reproduce

  1. Make sure letras.com is in the sources
  2. Manual search for lyrics
  3. Inspect results

Expected behavior

Expected: No hit when letras.com doesn't have any. What happens: it picks something from the same artist. Example of an artist it has so few that the "pattern" or lack thereof is easy to see, and an album that is freely available: https://soliloquium.bandcamp.com/album/an-empty-frame . https://www.letras.com/soliloquium/ has one of the songs and gets that right - for the others, it just picks one. Titles aren't close enough for that to be reasonable: 1: "Eye of the Storm" it returns lyrics to "The Discarded" 2: "Earthly Confine" it returns the lyrics to "Dead Ends". Same does track 5. "The Observer" 3: "The Sorrow Path" it returns the lyrics to "Catharsis". Same does track 6. "Procession" and track 7. "Fear Not". 4: "With or Without" it has and does correctly

Versions