jadell / neo4jphp

PHP wrapper of the Neo4j REST interface
Other
532 stars 137 forks source link

Process errors in batch streaming #117

Closed mitom closed 4 years ago

mitom commented 10 years ago

Using streams and batches at the same time changes their behaviour a bit. The batch returned will contain a status key for the individual operations and the status code of the response will be 200. This results in errors being hidden while transactions fail.

If it is not a streamed batch the overall status code of the request should work as was expected before and the individual operations should not have codes of their own, that's why it uses 200 (as it did before) on missing statuses.

jadell commented 10 years ago

Can you write a test case for the behavior in Client_Batch_NodeTest.php? One tests for a batch response with all 200-level sub-responses, and one test for a batch with a non-200 level sub-response?

mitom commented 10 years ago

@jadell Sorry for the half year delay, totally forgot about this. I rebased it to master and added the tests, however CI fails on some memcached test that I can't reproduce locally. I get all passes, no skips or errors. Any idea what could be causing it?

mmeloni commented 7 years ago

Any news?