jadenquinn / ivyroundup

Automatically exported from code.google.com/p/ivyroundup
0 stars 0 forks source link

Add support for Glassfish HK2 #433

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
I needed to have Glassfish HK2 in the repository. The attached patch is for 
this. 

I've split the project into separate modules rather than using a single module 
with multiple configurations. I'm not sure which I prefer (I'm erring away from 
the solution I've included).

The internal dependency chart looks something like this:

     osgi-resource-locator  hk2-utils
                ^           ^   ^   ^
                |           |   |   |
                +------+----+   |   |
                       |        |   |
                       +        |   |
                    hk2-api     |   |
                       ^        |   |
                       |        |   |
                       |        |   |
                       +        +   |
                      hk2-locator   |
                          ^         |
                          |         |
                          |         +
                          +----+hk2-core

Given that the modules need to be the same revision number (2.2.0-b10) there's 
some argument for keeping these altogether in the same module. However, 
glassfish HK2 also has some other modules which would need to be added although 
I'm not sure which.

The top-level maven project lists:

o hk2-utils
o hk2-api
o config-types
o (hk2-)core
o hk2-config
o hk2-locator
o hk2-runlevel
o class-model

Looking at the "getting started" page for HK2, there's clearly some argument 
for supplying all of these modules. 

So, the attached is probably not ready for committing yet. Do you have a 
preference for either a split module (as I've created here) or a combined 
module with multiple configurations?

Original issue reported on code.google.com by steven.n...@gmail.com on 29 Jul 2013 at 2:01

GoogleCodeExporter commented 8 years ago
A combined module is preferrable I think. This makes maintenance easier, and if 
the configurations are defined well it doesn't preclude anyone from picking and 
choosing the same way as they would be able to with distinct modules.

Original comment by archie.c...@gmail.com on 29 Jul 2013 at 2:04

GoogleCodeExporter commented 8 years ago
If we make this a single module, it'd have the following features:

Org: org.glassfish
Mod: hk2
Rev: 2.2.0-b10

Confs:
  * Utils
  * API [extends Utils]
  * Locator [extends Utils, API]
  * Core [extends Locator, Utils]
  * Config [extends Core]
  * RunLevel [extends API, Locator]

Original comment by steven.n...@gmail.com on 29 Jul 2013 at 2:13

GoogleCodeExporter commented 8 years ago
Actually, I'm not so sure about the group name now I think about it. The 
osgi-resource-locator should really be in the org.glassfish.hk2 group as that 
is it's package name. So that means that the rest should be in the same group 
too. So, I'm going to go with:

Org: org.glassfish.hk2
Mod: hk2
Rev: 2.2.0-b10

Org: org.glassfish.hk2
Mod: osgi-resource-locator
Rev: 1.0.1

Original comment by steven.n...@gmail.com on 29 Jul 2013 at 2:21

GoogleCodeExporter commented 8 years ago
[ Grrrr, I've only gone and committed the sin of "It's" / "Its" ]

Original comment by steven.n...@gmail.com on 29 Jul 2013 at 2:22

GoogleCodeExporter commented 8 years ago
New, single module version attached.

Original comment by steven.n...@gmail.com on 29 Jul 2013 at 3:21

Attachments:

GoogleCodeExporter commented 8 years ago
Looks good, added in r2769.

Original comment by archie.c...@gmail.com on 29 Jul 2013 at 3:32