search

jaegertracing / helm-charts

Helm Charts for Jaeger backend
Apache License 2.0
269 stars 347 forks source link

[Feature]: Add toleration to cassandra-schema-job manifest file #546

Open araamini opened 8 months ago

araamini commented 8 months ago

Requirement

For specific taint and toleration added to cassandra-schema-job.yaml file, it can be passed through values.yaml file.

Problem

There is no any option for specific toleration settings of cassandra-schema-job

Proposal

add the following lines to cassandra-schema-job.yaml

{{- with .Values.schema.tolerations }}
  tolerations:
    {{- toYaml . | nindent 8 }}
{{- end }}

Open questions

No response

tigroo commented 3 months ago

Hi everybody, I'm blocked on this lack too (and it's a classic way to pilot all the Kubernetes nodes using taints). I think it could be great to enhance nodeSelector, affinity and tolerations on the same way the collector e.g.:

      nodeSelector:
        {{- toYaml . | nindent 8 }}
      {{- end }}
    {{- with .Values.collector.affinity }}
      affinity:
        {{- toYaml . | nindent 8 }}
    {{- end }}
    {{- with .Values.collector.tolerations }}
      tolerations:
        {{- toYaml . | nindent 8 }}`
    {{- end }}

There: https://github.com/jaegertracing/helm-charts/blob/26e64394225377dd2cf814e4a21f3477b46c30c6/charts/jaeger/templates/collector-deploy.yaml#L203C1-L213C36