jaegertracing / jaeger-operator

Jaeger Operator for Kubernetes simplifies deploying and running Jaeger on Kubernetes.
https://www.jaegertracing.io/docs/latest/operator/
Apache License 2.0
1.03k stars 345 forks source link

Preparing release v1.59.0 #2608

Closed frzifus closed 3 months ago

frzifus commented 5 months ago

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

pavolloffay commented 5 months ago

@frzifus I think it would make sense reject the request to the webhook when the mode is set to the sidecar. Now it seems only args are checked https://github.com/jaegertracing/jaeger-operator/pull/2497/files#diff-32094fefd1a64042b98c218228dd2d9b3e52ffcacc06f939ad6dabfdd7fb17a2R99

frzifus commented 4 months ago

Some deployments fail:

Deployment does not have minimum availability.

status:
-  readyReplicas: 1
+  conditions:
+  - lastTransitionTime: "2024-06-27T07:56:55Z"
+    lastUpdateTime: "2024-06-27T07:56:55Z"
+    message: Deployment does not have minimum availability.
+    reason: MinimumReplicasUnavailable
+    status: "False"
+    type: Available
+  - lastTransitionTime: "2024-06-27T07:56:55Z"
+    lastUpdateTime: "2024-06-27T07:56:55Z"
+    message: ReplicaSet "simple-streaming-ingester-5d586cb4d6" is progressing.
+    reason: ReplicaSetUpdated
+    status: "True"
+    type: Progressing
+  observedGeneration: 1
+  replicas: 1
+  unavailableReplicas: 1
+  updatedReplicas: 1
frzifus commented 3 months ago

If otlp is enabled and no explicit port for grpc or http is configured, we change the default address from localhost to 0.0.0.0. See:

frzifus commented 3 months ago

FTR: We skipped 1.58. image

yurishkuro commented 3 months ago

Maybe you want to skip 1.59 and go to 1.60 (just released)?