search

jaegertracing / jaeger-operator

Jaeger Operator for Kubernetes simplifies deploying and running Jaeger on Kubernetes.
https://www.jaegertracing.io/docs/latest/operator/
Apache License 2.0
1.03k stars 345 forks source link

[Bug]: 1.61 release missing yaml asset #2684

Closed nfuden closed 2 months ago

nfuden commented 2 months ago

What happened?

Release asset missing in 1.61.1

Likely due to https://github.com/jaegertracing/jaeger-operator/blame/main/.ci/prepare-release.sh#L16 not completing / committed?

Release asset should be able to be uploaded with gh without breaking anything.

From a cursory glance it looks like script should still work for next release even without fixing this bug and its easy to construct the yaml manually so this seems like a small update but also not a super important one.

Steps to reproduce

As a user following setup linked in the readme attempt a naive create call. This relies on the asset that is normally published on the release. In this case kubectl create -f https://github.com/jaegertracing/jaeger-operator/releases/download/v1.61.0/jaeger-operator.yaml -n observability

Expected behavior

Asset exists to ease new users in.

iblancasa commented 2 months ago

Thanks, @nfuden, for letting us know. The GitHub workflow didn't finish properly, and the release was not completed. I ran it again, and now everything is there.

Thanks again.