search

jaegertracing / jaeger

CNCF Jaeger, a Distributed Tracing Platform
https://www.jaegertracing.io/
Apache License 2.0
20.6k stars 2.45k forks source link

[jaeger-v2]: Remove SkipBinaryAttrs flag from storage integration #5341

Closed james-ryans closed 6 months ago

james-ryans commented 7 months ago

Requirement

As a contributor, I want to remove the SkipBinaryAttrs flag from storage integration test that was temporarily added to bypass the issue sourced from upstream dependency. Marked with this comment https://github.com/jaegertracing/jaeger/pull/5322#discussion_r1556346781.

Problem

The SkipBinaryAttrs flag was added to bypass upstream issue because OTEL pkg/translator/jaeger has a bug that converts Jaeger proto BINARY type tags into OTLP STRING type but remains in STRING type when converted back into Jaeger proto.

Proposal

Remove SkipBinaryAttrs flag from storage integration test once the issue at https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/32208 has been resolved.

Open questions

No response

prakrit55 commented 6 months ago

hey @james-ryans. @yurishkuro I would like to work on it

james-ryans commented 6 months ago

Hi @prakrit55, actually we have an ongoing PR for this at #5436.