search

jagi / meteor-astronomy

Model layer for Meteor
https://atmospherejs.com/jagi/astronomy
MIT License
604 stars 67 forks source link

Cannot scroll in documentation #137

Closed rclai closed 8 years ago

lukejagodzinski commented 9 years ago

Mobile or desktop?

rclai commented 9 years ago

Desktop.

rclai commented 9 years ago

Chrome.

lukejagodzinski commented 9 years ago

Hmm it's strange. Can you describe it in more details? It's just stuck or it does not show or something else?

rclai commented 9 years ago

It tries to scroll but it keeps getting stuck at the top of a section.

rclai commented 9 years ago

I can scroll up, but it snaps to the top of the section.

lukejagodzinski commented 9 years ago

What browser are you using?

rclai commented 9 years ago

Chrome 46.0.2490.71 m.

dalcib commented 9 years ago

The same for me. Chrome 45.0.2454.101 m

lukejagodzinski commented 9 years ago

What operating system?

On Mon, Oct 19, 2015 at 3:08 PM, Dalci de Jesus Bagolin < notifications@github.com> wrote:

The same for me. Chrome 45.0.2454.101 m

— Reply to this email directly or view it on GitHub https://github.com/jagi/meteor-astronomy/issues/137#issuecomment-149207982 .

rclai commented 9 years ago

Windows 7.

dalcib commented 9 years ago

windows 8.1

lukejagodzinski commented 9 years ago

Ok I will take a look at it.

roelvan commented 9 years ago

Same issue here on a mac (chrome). Both touchpad and mouse wheel.

roelvan commented 9 years ago

By the way I want to thank you (@jagi) for this great package and the extended documentation. A real pleasure to use your package. You rock!

lukejagodzinski commented 9 years ago

I will have to make further tests. I've experience the same problem in Chrome on Android. I'll debug it tonight.

@roelvan thanks for good words :)

space-alien commented 9 years ago

I wonder if the animated progress bar is somehow to blame? It seems that scroll position is affected after the progress bar animation finishes.

By the way, this problem makes the docs completely impossible to use on Chrome Android.

lukejagodzinski commented 9 years ago

No progress bar is not the problem. The problem is in calculating current section based on the scroll position.

lukejagodzinski commented 9 years ago

Ok I've fixed it temporarily by splitting documentation into separate pages. I will prepare entirely new documentation page soon. Let me know if you can read it now.

space-alien commented 9 years ago

Thanks, that works ;) - tested on Chrome/Android.

One thing I note is that scrolling still feels very laggy on Chrome/Android. I wonder if perhaps the way the progress bar responds to scroll is a bit too keen? Perhaps a buffer to introduce a brief delay before updating the progress bar after the last scroll event might help, assuming there isn't one already.

Really enjoying my time learning about Astronomy so far - can't wait to work with it. Thanks for such a great tool.

lukejagodzinski commented 9 years ago

@space-alien I'm using the _.throttle function with a time set to 200ms so it's only doing 5 updates in a second. I've been testing documentation on Galaxy S4 and it work smooth. What phone do you have? I will probably remove progress bar in the future. It was good in a long documentation format but I'm going to keep it paginated so there will be no need for the progress bar.

Thanks, enjoy :)

space-alien commented 9 years ago

Sorry for the slow reply. Funnily enough, I'm also using an S4 and still seeing really laggy scrolling in Chrome.

In the native browser on the S4, scrolling is fine, but sadly the menu doesn't work.

Anyway, maybe this should remain a low priority since it's not affecting desktop.

lukejagodzinski commented 9 years ago

Hmm ok I will figure something out. I will prepare a new version in near future without such things like progress indicator.

roelvan commented 9 years ago

@jagi I also think it’s much easier to have one long page so that you can do a quick CMD+F/CTRL+F to find something back.

Did you check out Readme.io? It’s free for open source projects and looks quite solid. You can find an example here.