search

jagrosh / DiscordIPC

Connect locally to the Discord client using IPC for a subset of RPC features like Rich Presence and Activity Join/Spectate
Apache License 2.0
142 stars 47 forks source link

Gradle #9

Closed NoEffex closed 6 years ago

NoEffex commented 6 years ago

I'm going to preface this with the fact that I am not at all expecting this to be merged as there is already an existing Maven project in place and no real reason to switch. This pull request is just in case you decide you want to switch as I did this in order to quickly create a fat JAR in a consistent way and it took no longer than 5 minutes. It is my opinion that Gradle is easier to work with than Maven directly but again I completely understand if you don't agree or just don't want to make the unnecessary switch.

Shengaero commented 6 years ago

"I'm going to preface this with the fact that I am not at all expecting this to be merged..."

I mean if you're going to open a PR at least do it with some confidence...

I appreciate the effort, but as much as I agree with you that Gradle is arguably simpler and more dynamic than Maven, I'm just going to close this because this most likely won't change for any reason.

NoEffex commented 6 years ago

Hi, I had done it for my own purposes and didn't expect it to be merged so no problem at all. I worded it carefully as a lot of projects will treat such pull requests with hostility as nobody enjoys some random developer telling them how to run their projects and I wanted to make it clear I was not trying to tell you how to run your project or what changes you should make :)