Save buttons for system preferences should be yellow

[kfischer]

When editing an itemtype, the save button is yellow, but on other pages, like system preferences, the button is not really a button (no hover effect) and not yellow.

[mrenvoize]

I think we need a really clear style guide for when different button types should be used.

I agree here, I think the yellow is correct

[kfischer]

I think we are moving in the right direction here, but I didn't account for the fact that the buttons only activate when you changed a preference. This now causes a contrast issue on the 'unactivated' buttons.

Two options I think:

• Use the yellow only for activated buttons, that would make them stand out nicely and maybe a grey for unactivated?
• Improve contrast on the text/background, but we will still need a way to distinguish states

[jajm]

I'm not sure which patch did that, but it's a little bit better now:

[kfischer]

It's a little better, but it looks like we are still failing the WCAG for contrast on those buttons.

[jajm]

By "those buttons", do you mean the yellow buttons (whatever their state is), or the yellow disabled buttons specifically ?

[kfischer]

We might be failing both (struggling a little with the tool), but the yellow diabled are worse.

[mrenvoize]

My accessibility checker considers the contrasts good here.. lets close this one.