search

jakartaee / cdi

CDI specification
Apache License 2.0
215 stars 78 forks source link

Exclude the overview.html javadoc file from source #735

Closed starksm64 closed 10 months ago

starksm64 commented 11 months ago

Fixes #734

Azquelt commented 10 months ago

I had a look into why this happens. I think it's because we're listing the overview.html as a resource, which is really declaring that it should be included in the output jar. However, for some reason, when targetPath is an absolute path, it doesn't get included in the main jar with that path but does get included in the sources jar. :confused:

It looks like it's only been included as a resource in order to enable filtering to replace placeholders in the file? I've made a PR to do this with a separate goal rather than including it as a resource: #745

Azquelt commented 10 months ago

This also explains why it doesn't appear in the EL API, that overview file hasn't had placeholders added and isn't configured as a resource.