search

jakartaee / platform-tck

Jakartaee-tck
Other
130 stars 109 forks source link

arquillian/appclient wip progress logging changes #1647

Open scottmarlow opened 2 weeks ago

scottmarlow commented 2 weeks ago

Make the appclient logging a little less verbose by default at line 86.

I'm not yet sure why the logged information at 122 doesn't show the ear deployment file name (instead it seems to show the client jar (which is part of the ear). It would be nice to show the top level deployment as well.

scottmarlow commented 2 weeks ago

@jamezp please review when you have a chance.

scottmarlow commented 2 weeks ago

Overall this seems reasonable. One question I'd ask though is will we always be running with DEBUG logs enabled? Given what is logged, I assume yes. If so, we might want to consider keeping them at INFO, but I don't have a strong opinion there.

I have to verify as currently, I have the platformtck/glassfish-runner/persistence-platform-tck/jakartaeetck/bin/ts.jte harness.log.traceflag=true which might influence some logging levels.