Open jamezp opened 3 weeks ago
The generatePom should probably not be used for any of these artifacts. I'm working on updating the basic testing included in the distribution job so these basic failures will be caught.
That makes sense to me. Feel free to close this or I'll be happy to. The more I'm thinking about it, the less it seems like a bug or issue at all.
what looks like some other utility JAR's.
Let's please not include those utility JARs. That's IMHO backwards. Only the actual tests should be included. Utility and tools jars can simply be fetched from Maven Central.
(actually, see the requirements for the core profile to (also?) release all the jars to Maven Central anyway)
IMHO again, the less we work with the archaic jars in zip archive, the better.
Then the jars should not be a part of the platform-tck so there is no confusion as to what constitutes the platform-tck release.
On Sun, Jan 26, 2025 at 10:31 AM Arjan Tijms @.***> wrote:
what looks like some other utility JAR's.
Let's please not include those utility JARs. That's IMHO backwards. Only the actual tests should be included. Utility and tools jars can simply be fetched from Maven Central.
(actually, see the requirements for the core profile to (also?) release all the jars to Maven Central anyway)
IMHO again, the less we work with the archaic jars in zip archive, the better.
— Reply to this email directly, view it on GitHub https://github.com/jakartaee/platform-tck/issues/1803#issuecomment-2614494735, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACRDMR3PHZOACUFNYOJ3OL2MUEUFAVCNFSM6AAAAABV2RQZL6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJUGQ4TINZTGU . You are receiving this because you were assigned.Message ID: @.***>
Then the jars should not be a part of the platform-tck so there is no confusion as to what constitutes the platform-tck release
They should indeed not be part of the platform TCK. We already have a repo that perfectly fits the scope, and that is https://github.com/eclipse-ee4j/jakartaee-tck-tools
Should that repository be moved under the jakartaee organization? Also, we should probably make a decision soon it feels like we're on borrowed time for the TCK :)
Should that repository be moved under the jakartaee organization? Also, we should probably make a decision soon it feels like we're on borrowed time for the TCK :)
+1
It could be moved the newer jakartaee
organization. We should review the contents at some point and retire unused projects to a legacy branch so that the active contained projects have less clutter around them.
I'm creating this as a general issue for what I'm seeing when downloading the
platform-tck-11.0.0-SNAPSHOT-dist.zip
.The first issue I've seen is with the artifacts content. After the archive is unzipped you end up with a
platform-tck-11.0.0-SNAPSHOT/artifacts
directory which contains the TCK JAR's and what looks like some other utility JAR's.This directory also includes a
pom.xml
which can seemingly be used to install the artifacts into local Maven repository. The contents of thepom.xml
looks like:The initial problem I'm seeing is the
generatePom
configuration is being set totrue
. In some cases this is okay, but we're missing all the dependency information from the TCK. We could add the missing dependencies to working POM and maybe this is the best solution. However, it's not obvious what all needs to be added.Just as an example when I attempt to run the
rest-platform-tck
I see this:If the correct
jakarta.tck:rest-platform-tck
POM is included and used for the install, we could avoid having to add all the dependencies.Please feel free to close this if this was intended and that vendors need to include the expected dependencies.