jakelandis / fsync_compare

Simple little application to compare fsync time between mmap vs. channel io for sequential writes
1 stars 3 forks source link

Refactor #1

Closed jordansissel closed 5 years ago

jakelandis commented 7 years ago

I agree that the implementation presented here is a bit cleaner, but I believe that the refactoring is missing a few of the points I wanted to be explicit about (some technical, some style):

Since it is a trivial project, i would prefer to keep it abit dirty over loosing some of the points above.

jakelandis commented 7 years ago

It looks like your branch is starting become more then just a dirty hack (like it is here). If you don't mind un-forking and creating a new project, I will deprecate this one via the readme and link to yours.

jakelandis commented 5 years ago

routine cleanup ...closing out this PR.