search

jakob / TableTool

A simple CSV editor for the Mac
MIT License
1.32k stars 93 forks source link

Support For Mojave Dark Mode #68

Open chrisgrande opened 5 years ago

chrisgrande commented 5 years ago

Changed table view to use system colors to provide support for Mojave Dark Mode. dark_mode

jakob commented 5 years ago

I'm not very happy with the color choices. Colors like unemphasizedSelectedTextBackgroundColor have a very specific function, and should not be used for unrelated things. Either use a custom color (use asset catalog to create custom color with light / dark mode), or use a color that is suitable from a semantic point of view (is there a system grid color?)

chrisgrande commented 5 years ago

It's a good point. I had tested gridColor but it was very dark and wasn't being correctly color mixed with the Desktop picture - this now seems to be the case with unemphasizedSelectedTextBackgroundColor which does't get mixed in Dark Mode. Changes in 10.14.2 perhaps?

I have switched to gridColor (it seems to be working correctly now) for the grid lines and kept the unused table sections as alternatingContentBackgroundColor as it does the right thing in Dark Mode and adapts to the Desktop Picture.

tyson90 commented 4 years ago

Any plans to merge it?

javinladish commented 4 years ago

I'd love to have dark mode on my Table Tool app. Any plans on updating the app to support dark mode?