jakoblind / webpack-autoconf

A tool to create frontend apps using webpack, Parcel or Snowpack
https://createapp.dev/
875 stars 78 forks source link

#108 fixed htmlWebpackPlugin template issue #138

Closed adardesign closed 3 years ago

jakoblind commented 3 years ago

Thank you! I get an error when building?

[webpack-cli] /Users/jakoblind/Downloads/empty-project - 2021-07-07T190639.843/webpack.config.js:38
                filename: \"index.html\",
                          ^

It generates webpack config that looks like this:

plugins: [
        new HtmlWebpackPlugin({
                templateContent: ({ htmlWebpackPlugin }) => '<!DOCTYPE html><html><head><meta charset=\"utf-8\"><title>'+htmlWebpackPlugin.options.title+'</title></head><body><div id=\"app\"></div></body></html>',
                filename: \"index.html\",
              }),

Think switching from " to ' on the line with filename would fix it.

jakoblind commented 3 years ago

@adardesign Do you want to look into this? If you don't have time right now, I could fix it. Want to get this improvement shipped :)

jakoblind commented 3 years ago

Thanks for your contribution!