search

jakubkulhan / bunny

Performant pure-PHP AMQP (RabbitMQ) sync/async (ReactPHP) library
MIT License
698 stars 101 forks source link

Fix: added PHP8.1 #123

Closed bckp closed 2 years ago

WyriHaximus commented 2 years ago

Thank you for taking the time to create this PR, but as #106 has just been merged and also includes this I'm closing this PR.

bckp commented 2 years ago

You have added tests etc, but do not edited composer.json, so PHP8.1 is still not supported from Composer perspective.... see https://getcomposer.org/doc/articles/versions.md#caret-version-range-

@WyriHaximus

WyriHaximus commented 2 years ago

@bckp It installs just fine on PHP 8.1 for me: image

And looking at that caret explanation it also matches PHP 8.1. Or are you experiencing something different?

bckp commented 2 years ago

Hmm, now installs fine... Sorry, it must be some dependency issue, as for me it always install 0.2.4... thanks @WyriHaximus

WyriHaximus commented 2 years ago

Don't hesitate to reach out if you run into any issues in the future