Version 2.0 - Githubissues

jamesmartin / inline_svg

Embed SVG documents in your Rails views and style them with CSS

MIT License

716 stars 73 forks source link

Version 2.0 #105

Open jamesmartin opened 5 years ago

jamesmartin commented 5 years ago

A laundry list of things we'd like to do for version 2.0:

[ ] Drop support for older Rails versions (ideally only support Rails 6 and Rails 5)
- We'll keep a v1 branch around and patched for security vulnerabilities while people migrate to v2
[ ] Remove the inline_svg helper in favor of the new specific helpers introduced in #103
[ ] ...

DanielJackson-Oslo commented 3 years ago

Would love to keep inline_svg as the default method, and instead be able to configure if it should point to sprockets or webpacker. Feels a bit weird to me to have to define in respective view files if I use sprockets or webpacker, and have to change all my svg view code if I change from one to the other!

jamesmartin commented 3 years ago

Feels a bit weird to me to have to define in respective view files if I use sprockets or webpacker, and have to change all my svg view code if I change from one to the other!

Agreed. 👍

DanielJackson-Oslo commented 3 years ago

Feels a bit weird to me to have to define in respective view files if I use sprockets or webpacker, and have to change all my svg view code if I change from one to the other!

Agreed. 👍

Does that mean we can get rid of the depreciation warning for using inline_svg? I can make a PR for that, if you'd like?