search

jamesmartin / inline_svg

Embed SVG documents in your Rails views and style them with CSS
MIT License
716 stars 73 forks source link

Missing array in cached_asset_file.rb #81

Closed LeahArmstrong closed 7 years ago

LeahArmstrong commented 7 years ago

Added an array where one appears to be missing. Causes this error in Rails 4.0.3:

/gems/inline_svg-1.3.0/lib/inline_svg/cached_asset_file.rb:17: syntax error, unexpected ',' (SyntaxError)
    def initialize(paths:, filters: [])

Fix suggested in https://github.com/jamesmartin/inline_svg/pull/80

jamesmartin commented 7 years ago

Only visible in Ruby versions older than 2.1, which introduced required keyword arguments. The fix from #80 has been merged. Thanks again, @DustinArmstrong! ✨

LeahArmstrong commented 6 years ago

@jamesmartin Would this be a candidate for a 1.3.1 release of the gem?

jamesmartin commented 6 years ago

Would this be a candidate for a 1.3.1 release of the gem?

@DustinArmstrong yes, if it's helpful I can make a new release today.

jamesmartin commented 6 years ago

v1.3.1 was released today.