search

jamesmontemagno / SettingsPlugin

Read and Write Settings Plugin for Xamarin and Windows
MIT License
324 stars 80 forks source link

Support for .NETStandard? #22

Closed FroggieFrog closed 8 years ago

FroggieFrog commented 8 years ago

Feature Request:

Ist it possible to support .NetStandard? It is written everywhere to use .NetStandard instead of PCLs, but this plugin is not compatible (yet).

Package Manager console: Package Xam.Plugins.Settings 2.5.1 is not compatible with netstandard1.4 (.NETStandard,Version=v1.4). Package Xam.Plugins.Settings 2.5.1 supports:

See: https://blogs.msdn.microsoft.com/dotnet/2016/09/26/introducing-net-standard/ (section: As a library author, what should I do now?)

InquisitorJax commented 8 years ago

try adding PCL Compatibility in your .NET Standard lib json file. See here Add this: "imports": "portable-net45+win8+wpa81+wp8"

Note that I removed the square [ ] brackets that are used in the linked article.

FroggieFrog commented 8 years ago

When I add the imports-section, then I can use the the plugin. But it would be better/simpler if it "just works". :-)

My project.json (for completeness): { "supports": {}, "dependencies": { "Microsoft.NETCore.Portable.Compatibility": "1.0.1", "NETStandard.Library": "1.6.0", "Newtonsoft.Json": "9.0.1", "Xam.Plugin.Connectivity": "2.2.12", "Xam.Plugins.Settings": "2.5.1" }, "frameworks": { "netstandard1.4": { "imports": "portable-net45+win8+wp8+wpa81" } } }

InquisitorJax commented 8 years ago

maybe close the issue since it's solved?

jamesmontemagno commented 8 years ago

I will add full .NET standard support when 2.0 comes out soon.